gh-136728: Combine OpenSSL and AWS-LC CI configurations#144805
Draft
zware wants to merge 5 commits intopython:mainfrom
Draft
gh-136728: Combine OpenSSL and AWS-LC CI configurations#144805zware wants to merge 5 commits intopython:mainfrom
zware wants to merge 5 commits intopython:mainfrom
Conversation
zware
added
tests
zware
commented
Feb 13, 2026
.github/workflows/build.yml
Outdated
| # Keep 1.1.1w in our list despite it being upstream EOL and otherwise | ||
| # unsupported as it most resembles other 1.1.1-work-a-like ssl APIs | ||
| # supported by important vendors such as AWS-LC. | ||
| version: 1.1.1w |
Member
Author
There was a problem hiding this comment.
Since we actually include AWS-LC tests now, can we remove this note and version?
hugovk
reviewed
Feb 13, 2026
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Yeah, this approach also looks fine by me :)
.github/workflows/build.yml
Outdated
| # Keep 1.1.1w in our list despite it being upstream EOL and otherwise | ||
| # unsupported as it most resembles other 1.1.1-work-a-like ssl APIs | ||
| # supported by important vendors such as AWS-LC. | ||
| version: 1.1.1w |
Collapse matrix entries into more concise one line each.
Remove obsolete OpenSSL 1.1.1w; AWS-LC is roughly 1.1.1-shaped and exercises the relevant APIs.
Remove AWS-LC 1.55.0; just test the single latest version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally started this before finding GH-143940, but given the somewhat different approach I figured it was worth sharing anyway. If we prefer the GH-143940 approach, this can just be closed.